Skip to content

Drop trace.force in CaptureSet #21531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Drop trace.force in CaptureSet #21531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a95e89
Drop trace.force in CaptureSet
dwijnand Sep 3, 2024
2fbd42e
Drop if in CaptureSet
dwijnand Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/cc/CaptureSet.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ sealed abstract class CaptureSet extends Showable:
*/
def accountsFor(x: CaptureRef)(using Context): Boolean =
if comparer.isInstanceOf[ExplainingTypeComparer] then // !!! DEBUG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove or comment out the if.

reporting.trace.force(i"$this accountsFor $x, ${x.captureSetOfInfo}?", show = true):
reporting.trace(i"$this accountsFor $x, ${x.captureSetOfInfo}?", show = true):
elems.exists(_.subsumes(x))
|| !x.isMaxCapability && x.captureSetOfInfo.subCaptures(this, frozen = true).isOK
else
Expand Down