Skip to content

fix: Change the NamedTuple.apply method to transparent inline #21664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Change the NamedTuple.apply method to transparent inline #21664

wants to merge 1 commit into from

Conversation

@KacperFKorban
Copy link
Member

@KacperFKorban KacperFKorban commented Sep 27, 2024 •
edited
Loading

This fixes a problem with not being able to reference named tuple fields immediately from a named tuple literal

possible fix for #21413

@KacperFKorban
fix: Change the NamedTuple.apply method to transparent inline
739b40e 
This fixes a problem with not being able to reference named tuple fields
immediately from a named tuple literal
sjrd
sjrd reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty extreme change. transparent is not to be used lightly. It puts a lot more constraints on future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KacperFKorban @sjrd