Skip to content

Conversation

@charpov
Copy link
Contributor

@charpov charpov commented Oct 2, 2024

The documentation for zipAll is incorrect, e.g., List(1, 2, 3).zipAll(Set("x"), 0, "") produces a list, not a set.

The documentation for zipAll is incorrect, e.g., List(1, 2, 3).zipAll(Set("x"), 0, "") produces a list, not a set.
@hamzaremmal
Copy link
Member

@charpov Thanks for your contribution ! For this PR to be merged, can you please sign the Scala CLA here. Once done, I will restart the CI's job and merge the PR.

@hamzaremmal
Copy link
Member

hamzaremmal commented Oct 2, 2024

We should also port the change to the scala/scala repository here. @charpov would you like to do it or should I open a PR?

@charpov
Copy link
Contributor Author

charpov commented Oct 2, 2024

I signed the CLA.
I'm still new to PRs, so someone else might be faster at starting in the other repository. Otherwise, I'll try.

@hamzaremmal
Copy link
Member

hamzaremmal commented Oct 3, 2024

I signed the CLA.

Great, thanks !

I'm still new to PRs, so someone else might be faster at starting in the other repository. Otherwise, I'll try.

Sure no worries. I will open one and ping you there.

@hamzaremmal hamzaremmal merged commit 861e6ff into scala:main Oct 3, 2024
28 checks passed
hamzaremmal added a commit to hamzaremmal/scala2 that referenced this pull request Oct 4, 2024
Originally submitted in scala/scala3#21692

Co-authored-by: Michel Charpentier <[email protected]>
SethTisue pushed a commit to hamzaremmal/scala2 that referenced this pull request Oct 22, 2024
Originally submitted in scala/scala3#21692

Co-authored-by: Michel Charpentier <[email protected]>
hamzaremmal added a commit to hamzaremmal/scala3 that referenced this pull request May 2, 2025
Originally submitted in scala#21692

Co-authored-by: Michel Charpentier <[email protected]>
hamzaremmal added a commit that referenced this pull request May 7, 2025
Originally submitted in #21692

Co-authored-by: Michel Charpentier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants