Draft: Overloading result-based pruning shouldn't prefer inapplicable alt #21730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alt If an overloaded alternative in `alts` does not end up being part of the `candidate` list in `resolveOverloaded1`, then it is not applicable to the current arguments and should not be considered by `adaptByResult`. This avoids discarding working solutions in favor of invalid ones when the working solution involves a match type in the method result type that will fail `resultConforms`. Fixes scala#21410.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an overloaded alternative in
altsdoes not end up being part of thecandidatelist inresolveOverloaded1, then it is not applicable to the current arguments and should not be considered byadaptByResult. This avoids discarding working solutions in favor of invalid ones when the working solution involves a match type in the method result type that will failresultConforms.Fixes #21410.