Revert dubious retry in vulpix #21801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
added
the
area:vulpix
som-snytt
added
the
fasttrack
|
Taking |
|
@som-snytt might need to rebase this |
prolativ
approved these changes
Feb 21, 2025
|
I think I was hoping to get the lazyvals change in by fasttracking. |
som-snytt
force-pushed
the
revert/vulpix-retry
branch
from
931520a to
72bff19
Compare
hamzaremmal
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #17373 which introduced a retry in the test rig, but of dubious utility.
At some point, I stopped seeing those timeouts. I never found a root cause; I don't see timeouts using 3.3.0 and JDK 17. This is under WSL2/Ubuntu.
Also use@nowarnforUnsafeAPI.