Rename @unbox to @use.
#21861
Closed
Rename @unbox to @use.
#21861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we violated that assumption is we too the deep capture set of a capture reference wiht singleton type.
Count in dcs exactly those locations where a cap gets replaced by a reach capability.
Simplify code that handles applications, avoiding adding pieces of mutable state.
The correct point to address charging reach capabilities is in markFree itself: When a reach capability goes out of scope, and that capability is not a parameter, we need to continue with the underlying capture set.
Merged
odersky
added
the
cc-experiment
|
Superseded by #21863 |
noti0na1
added a commit
that referenced
this pull request
Nov 22, 2024
A refactored and consolidated capture checker without any drastic changes to the algorithm. The main changes are: - Go back to the "sealed" policy where we check that type parameters do not contain `cap` instead of checking that we do not box or unbox `cap`. - Rename `@unbox` to `@use` - Fix several soundness holes relating to reach capabilities Based on #21861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, several refactorings and fixes to the way we handle applications and markFree. This PR reflects the state of how we can improve the capture checker with fixes and simplifications without changing anything fundamental in the policies.