Skip to content

Revert "Drop inaccessible subclasses from refineUsingParent" #21895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Revert "Drop inaccessible subclasses from refineUsingParent" #21895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/core/Decorators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ object Decorators {
case _ => String.valueOf(x).nn

/** Returns the simple class name of `x`. */
def className: String = if x == null then "<null>" else x.getClass.getSimpleName.nn
def className: String = x.getClass.getSimpleName.nn

extension [T](x: T)
def assertingErrorsReported(using Context): T = {
Expand Down
6 changes: 1 addition & 5 deletions compiler/src/dotty/tools/dotc/core/TypeOps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,11 +930,7 @@ object TypeOps:
for tp <- mixins.reverseIterator do
protoTp1 <:< tp
maximizeType(protoTp1, NoSpan)
val inst = wildApprox(protoTp1)
if !inst.classSymbol.exists then
// E.g. i21790, can't instantiate S#CA as a subtype of O.A, because O.CA isn't accessible
NoType
else inst
wildApprox(protoTp1)
}

if (protoTp1 <:< tp2) instantiate()
Expand Down
14 changes: 0 additions & 14 deletions tests/pos/i21790.scala
View file
Open in desktop

This file was deleted.

Loading