Skip to content

Backport "Fix extending protected nested java classes" to LTS #22141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 4, 2024
Merged

Backport "Fix extending protected nested java classes" to LTS #22141

merged 3 commits into from
Dec 4, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #21857 to the 3.3.5.

PR submitted by the release tooling.

dwijnand and others added 3 commits December 4, 2024 14:05
@dwijnand @WojciechMazur
Fix extending protected nested java classes
f9a0010 
PR 21362 added an accessibility fix to Erasure, but that revealed a
mistake in determining the accessibility of inner java classes, which
I'm now fixing.

[Cherry-picked 17dadf7]
@dwijnand @WojciechMazur
Set privateWithin when creating java inner classes
54c9ce7 
[Cherry-picked 350215d]
@WojciechMazur
Push java inner class privateWithin setting
023d0a2 
[Cherry-picked 14e46e8][modified]
Base automatically changed from backport-lts-3.3-21597 to lts-3.3 December 4, 2024 17:22
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to backport-lts-3.3-21857.

Reference

@WojciechMazur WojciechMazur merged commit 5f2d7ef into lts-3.3 Dec 4, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the backport-lts-3.3-21857 branch December 4, 2024 17:22
@WenjunHuang WenjunHuang mentioned this pull request May 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WojciechMazur @dwijnand