Presentation compiler: Add completions for named patterns #22251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
force-pushed
the
named-pattern-completions
branch
from
8aa208f to
cc0c444
Compare
kasiaMarek
reviewed
Jan 7, 2025
Comment on lines
+168
to
+171
| def unapply(path: List[untpd.Tree]): Boolean = | ||
| path match | ||
| case (_: untpd.Ident) :: (fn0: untpd.Apply) :: untpd.CaseDef(fn1, _, _) :: _ | ||
| if fn1 == fn0 && fn0.args.exists(_.isInstanceOf[untpd.NamedArg]) => true |
There was a problem hiding this comment.
What if it's nested:
case Some(User(nam@@)) =>or is this covered by some other case?
Comment on lines
+41
to
+42
| rest.collectFirst: // We can't complete names without knowing the type of selector | ||
| case Match(selector, _) => selector |
There was a problem hiding this comment.
Won't this fail for nested named tuples?
Comment on lines
+68
to
+72
| private object NamedTupleUnapplyResultType: | ||
| def unapply(tree: Type)(using Context): Option[Type] = tree match | ||
| case AppliedType(TypeRef(_, cls), (namedTuple @ defn.NamedTuple(_, _)) :: Nil) | ||
| if (cls == ctx.definitions.OptionClass || cls == ctx.definitions.SomeClass) => Some(namedTuple) | ||
| case _ => None |
Comment on lines
+83
to
+87
| val maybeApplied = tree match | ||
| // The check for case flag is necessary to filter introduced type bounds T$1..n | ||
| case tpeApply @ TypeApply(_, args) if !args.exists(_.symbol.flags.is(Flags.Case)) => | ||
| apply.info.appliedTo(args.map(_.tpe)) | ||
| case _ => apply.info |
There was a problem hiding this comment.
Can you simplify and always do:
apply.info.appliedTo(args.map(_.tpe))
| // introduced in this commit | ||
| ) | ||
|
|
||
| // TODO Leaving this test as I want to make it work in the future, same for named args |
There was a problem hiding this comment.
Can you create an issue and relate this to the issue?
| ) | ||
|
|
||
| // TODO completion for binds but only in backtics | ||
| // @Test def `named-tuples-bind-with-named-patterns-3` = |
There was a problem hiding this comment.
Can you create an issue and relate this to the issue?
natsukagami
reviewed
Jan 14, 2025
| case GenericImportOrExport() => Mode.ImportOrExport | Mode.Scope // import TrieMa@@ | ||
| case BindMixedWithNamedPatterns() => Mode.None // case User(name = name, sur@@) | ||
| case untpd.Literal(Constants.Constant(_: String)) :: _ => Mode.Term | Mode.Scope // literal completions | ||
| // TODO case (_: tpd.Bind) :: _ => we should complete only when in backticks |
There was a problem hiding this comment.
Is this intentionally left as TODO?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds completion capabilities for named patterns.
Also adds comment that we should add backtick term completion in Bind position but only when we are inside backticks.