Update ScAS : adapt to new given syntax #22302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjolly
force-pushed
the
main
branch
2 times, most recently
from
3a516df to
140ebb6
Compare
rjolly
force-pushed
the
main
branch
2 times, most recently
from
ce82cdf to
6590955
Compare
|
Do you have a link to the PR where you made the needed changes? I'd be interested to see it, just out of curiosity. |
|
@SethTisue Unfortunately, I do not use PRs (yet?). It's essentially in dotty-staging/scas@4ef0d85 . Other than that, the main burden was to change abstract givens to the new |
SethTisue
approved these changes
Feb 26, 2025
|
I see this got forgotten about. Once CI likes it, @ me and I'll merge it. |
|
@SethTisue It is ready, you can go ahead. Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.