Skip to content

Fix cyclic check, regardless of definition order #22342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix cyclic check, regardless of definition order #22342

merged 1 commit into from
Jan 22, 2025
+177 −16

Conversation

@dwijnand
Copy link
Member

Fixes #22257

@dwijnand dwijnand marked this pull request as ready for review January 11, 2025 00:30
@dwijnand dwijnand requested a review from SethTisue January 11, 2025 00:30
SethTisue
SethTisue approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to vouch for the typer details, but the code changes look safe & plausible and the testing looks nicely thorough.

@SethTisue SethTisue removed their assignment Jan 21, 2025
@dwijnand dwijnand merged commit 8c5b00d into scala:main Jan 22, 2025
29 checks passed
@dwijnand dwijnand deleted the i22257-cyclic branch January 22, 2025 10:38
@WojciechMazur WojciechMazur added this to the 3.7.0 milestone Mar 11, 2025
This was referenced Apr 3, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SethTisue SethTisue SethTisue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

(caught cyclic reference) error on type definitions that works on Scala 2

3 participants

@dwijnand @SethTisue @WojciechMazur