Allow nowarn subclasses #22762
Open
Allow nowarn subclasses #22762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to wait for a release and update of scala-library that includes scala/scala#10976, i.e. scala 2.13.17. Then I can delete the library classes I copied over, and rely on the ones in the stdlib. And I can add another copy of the separate compilation, where the annotation is compiled with scala-compiler 2.13.17. |
|
Capability unlocked! I can take a look if helpful. I see I added the conflicting |
|
This is somewhere on my list, but I won't get to it very soon... If you have a go, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the "User-defined annotation subclasses" part of #22414, and used it to handle
@nowarnsubclasses. The "Default expression ASTs" part doesn't have a real world use case for it, so I skipped it for now. And "Runtime uses of annotation classes" part was recently fixed in #22553.