Patch empty implicit parens on error recovery #22835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires a tweak: an implicit param list is not supplied implicitly if an arg list is present (but defaults may be supplied in the explicit application). It must not continue implicit application when rewriting. Ha, in other words, |
som-snytt
force-pushed
the
issue/22792-rewrite-bad-parens
branch
from
6fe89ef to
cfa8e9f
Compare
|
Added a test case for rewrite of |
som-snytt
force-pushed
the
issue/22792-rewrite-bad-parens
branch
from
c184805 to
83fda42
Compare
|
The spurious failure is cc timeout on posCC, negAll, runAll. |
som-snytt
force-pushed
the
issue/22792-rewrite-bad-parens
branch
from
ef81b4a to
da154fc
Compare
som-snytt
commented
Apr 8, 2025
| case InfixTuple // r f (x1, ..., xN) where N != 1; needs to be treated specially for an error message in typedApply | ||
| case Regular // r.f(x) | ||
| case Using // r.f(using x) | ||
| case InfixTuple // r f (x1, ..., xN) where N != 1; needs to be treated specially for an error message in typedApply |
There was a problem hiding this comment.
This keeps the line under 120 chars, not a standard but nice to have when feasible. class Apply line wraps at that length; it would be nice to alias constructorOnly to cO or something like in chemistry K.
KacperFKorban
approved these changes
Jul 1, 2025
som-snytt
force-pushed
the
issue/22792-rewrite-bad-parens
branch
from
da154fc to
dc178d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer a rewrite for an erroneous application
f()where the parameter list isimplicitand a parameter lacks a default arg.This was never official syntax, but was accepted from 3.3.4/3.4.2 due to a bug. The rewrite is for 3.7-migration, using the existing
MigrationVersion.ImplicitParamsWithoutUsing, since that is a similar bit of syntax.Fixes #22792