improvement: Avoid recompiling in non-boostrapped projects #23017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we seem to recompile more than needed: ``` [info] Build triggered by /Users/tgodzik/Documents/dotty/presentation-compiler/test/dotty/tools/pc/tests/hover/HoverTermSuite.scala. Running 'scala3-presentation-compiler/testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *named-tuples5'. [info] compiling 27 Scala sources to /Users/tgodzik/Documents/dotty/compiler/target/scala-3.7.0-RC3/classes ... [info] compiling 4 Java sources to /Users/tgodzik/Documents/dotty/sbt-bridge/src/target/classes ... [info] compiling 1 Scala source to /Users/tgodzik/Documents/dotty/out/bootstrap/scala3-presentation-compiler/scala-3.7.1-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes ... ``` after changes to a test in PC I am not 100% why this was needed.
Member
|
I'm not able to reproduce this locally. If I change a the same test, I only have the expected number of compilations: sbt:scala3> scala3-presentation-compiler/testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *named-tuples5'
[info] compiling 1 Scala source to /Users/hamzaremmal/Desktop/scala/scala3/out/bootstrap/scala3-presentation-compiler-testcases/scala-3.7.1-RC1-bin-SNAPSHOT-nonbootstrapped/classes ...
[info] compiling 97 Scala sources to /Users/hamzaremmal/Desktop/scala/scala3/out/bootstrap/scala3-presentation-compiler/scala-3.7.1-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes ...
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite started
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite finished: 0 failed, 0 ignored, 0 total, 0.0s
[info] Passed: Total 0, Failed 0, Errors 0, Passed 0
[info] No tests to run for scala3-presentation-compiler / Test / testOnly
[success] Total time: 7 s, completed Apr 25, 2025, 1:27:28 PM
sbt:scala3> scala3-presentation-compiler/testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *named-tuples5'
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite started
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite finished: 0 failed, 0 ignored, 0 total, 0.0s
[info] Passed: Total 0, Failed 0, Errors 0, Passed 0
[info] No tests to run for scala3-presentation-compiler / Test / testOnly
[success] Total time: 2 s, completed Apr 25, 2025, 1:27:34 PM
sbt:scala3> scala3-presentation-compiler/testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *named-tuples5'
[info] compiling 1 Scala source to /Users/hamzaremmal/Desktop/scala/scala3/out/bootstrap/scala3-presentation-compiler/scala-3.7.1-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes ...
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite started
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite finished: 0 failed, 0 ignored, 0 total, 0.0s
[info] Passed: Total 0, Failed 0, Errors 0, Passed 0
[info] No tests to run for scala3-presentation-compiler / Test / testOnly
[success] Total time: 3 s, completed Apr 25, 2025, 1:28:31 PM
sbt:scala3> scala3-presentation-compiler/testOnly dotty.tools.pc.tests.hover.HoverTermSuite -- *named-tuples5'
[info] compiling 1 Scala source to /Users/hamzaremmal/Desktop/scala/scala3/out/bootstrap/scala3-presentation-compiler/scala-3.7.1-RC1-bin-SNAPSHOT-nonbootstrapped/test-classes ...
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite started
[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite finished: 0 failed, 0 ignored, 0 total, 0.0s
[info] Passed: Total 0, Failed 0, Errors 0, Passed 0
[info] No tests to run for scala3-presentation-compiler / Test / testOnly
[success] Total time: 3 s, completed Apr 25, 2025, 1:29:25 PM
[info] Publishing build scan...@tgodzik any more info about how this manifests itself. Otherwise, we should close the PR, the previous configuration is better imho. |
Contributor
Author
|
Ok, I will try to figure out what is going or add an option to turn off develocity locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we seem to recompile more than needed:
after changes to a test in PC
I am not 100% why this was needed.