Fix irrefutability checking in for with untupling
#23273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the two for comprehensions in the added test case behaved differently:
The second one was incorrect: just like the first one, we should use the
casekeyword to make the pattern partial since we're in a for comprehension, but this information was lost when callingmakeCaseLambdaintypedFunctionValue. To fix this, we need to retrieve the attachment in the scrutinee (it was added there bymakeSelectorcalled frommakeCaseLambdacalled frommakeLambdacalled frommakeForinDesugar.scala).