Skip to content

bugfix: Check for error before checking members of product type in getUnapplySelectors #23358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

bugfix: Check for error before checking members of product type in getUnapplySelectors #23358

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
248b9f1
Check for error type before checking members of product in getUnapply…
aherlihy Jun 12, 2025
af5d911
move test to neg
aherlihy Jun 12, 2025
4c2f6b3
Move error check into productSelectorTypes
aherlihy Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ object Applications {
val isProduct = args match
case x :: xs => x.isInstanceOf[untpd.NamedArg] || xs.nonEmpty
case _ => false
if isProduct && !tp.derivesFrom(defn.SeqClass) then
if isProduct && !tp.derivesFrom(defn.SeqClass) && !tp.isError then
productUnapplySelectors(tp).getOrElse:
// There are unapplys with return types which have `get` and `_1, ..., _n`
// as members, but which are not subtypes of Product. So `productUnapplySelectors`
Expand Down
6 changes: 6 additions & 0 deletions tests/neg/i23156.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
object Unpack {
(1, 2) match {
case Unpack(first, _) => first
}
def unapply(e: (Int, Int)): Option[T] = ??? // error
}
Loading