Skip to content

Don't expand name of ctor default arg #23478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't expand name of ctor default arg #23478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/src/dotty/tools/dotc/core/SymDenotations.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,10 @@ object SymDenotations {

/** The expanded name of this denotation. */
final def expandedName(using Context): Name =
if (name.is(ExpandedName) || isConstructor) name
if name.is(ExpandedName) || isConstructor
|| name.is(DefaultGetterName) && name.match { case DefaultGetterName(nme.CONSTRUCTOR, _) => true case _ => false }
then
name
else name.expandedName(initial.owner)
// need to use initial owner to disambiguate, as multiple private symbols with the same name
// might have been moved from different origins into the same class
Expand Down
4 changes: 2 additions & 2 deletions compiler/src/dotty/tools/dotc/transform/ExpandPrivate.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ import ValueClasses.*
* This is necessary since private methods are not allowed to have the same name
* as inherited public ones.
*
* Also, make non-private any private constructor that is annotated with `@publicInBinary`.
* (See SIP-52)
* Also, make non-private any private constructor that is annotated with `@publicInBinary`.
* (See SIP-52)
*
* See discussion in https://github.com/scala/scala3/pull/784
* and https://github.com/scala/scala3/issues/783
Expand Down
4 changes: 4 additions & 0 deletions tests/pos/i23477.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
//> using options -Ycheck:expandPrivate

class C private (x: Int, y: Int = 1):
def this() = this(1)
Loading