Avoid recursion when transforming types used in Holes #23595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the AvoidMap used in getPicklableHoleType would try to replace recursive type parameters obtained via F-bounds) with LazyRefs, which would expand to include another LazyRef, etc. Now we explicitly guard against recursing over already visited TypeRefs, instead replacing them with RecTypes (which are safe to pickle).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
AvoidMapused ingetPicklableHoleTypewould try to replace recursive type parameters (obtained via F-bounds) withLazyRefs, which would expand to include anotherLazyRef, etc. Now we explicitly guard against recursing over already visitedTypeRefs, instead replacing them withRecTypes(which are safe to pickle).Fixes #22996