Skip to content

Scaladoc Support for Capture & Separation Checking (Staging) #23607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 14, 2025
Merged

Scaladoc Support for Capture & Separation Checking (Staging) #23607

merged 5 commits into from
Aug 14, 2025

Conversation

bracevac
Copy link
Contributor

@bracevac bracevac commented Jul 26, 2025 •
edited
Loading

This is the staging version of #23471 to be merged into main.

Fixes #23437

@bracevac bracevac force-pushed the cc-scaladoc2 branch 3 times, most recently from 4519319 to 3d3caf7 Compare August 10, 2025 22:34
@bracevac
Copy link
Contributor Author

I think it's ready now.

hamzaremmal
hamzaremmal approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@hamzaremmal hamzaremmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some refactoring I believe, but with the given circumstances, I believe it does the job.

scaladoc/src/dotty/tools/scaladoc/ScaladocSettings.scala
BooleanSetting(RootSetting, "dynamic-side-menu", "Generate side menu via JS instead of embedding it in every html file", false)

val suppressCC: Setting[Boolean] =
BooleanSetting(RootSetting, "suppressCC", "Suppress rendering anything related to experimental capture checking", false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I suggest changing the setting to suppress-cc or Yno-cc. No other setting has capital letters in it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done when refactoring

@hamzaremmal hamzaremmal merged commit 88961de into scala:main Aug 14, 2025
45 checks passed
@hamzaremmal hamzaremmal deleted the cc-scaladoc2 branch August 14, 2025 16:25
This was referenced Aug 14, 2025
Open
Open
@WojciechMazur WojciechMazur mentioned this pull request Sep 20, 2025
Merged
WojciechMazur added a commit that referenced this pull request Sep 20, 2025
@WojciechMazur
Backport "Scaladoc Support for Capture & Separation Checking (Staging…
5e8efa4 
…)" to 3.7.4 (#23977)

Backports #23607 to the 3.7.4.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.7.4 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees

@bracevac bracevac

@natsukagami natsukagami

Labels
None yet
Projects
None yet
Milestone
3.7.4
Development

Successfully merging this pull request may close these issues.

Scaladoc Support for Capture Checking
4 participants
@bracevac @hamzaremmal @natsukagami @WojciechMazur