Skip to content

Keep deepened proto on AmbiguousImplicits even if cannot constrainResult #23687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

EugeneFlesselle
Copy link
Contributor

Might fix #23610
Related to #23664

@EugeneFlesselle
Copy link
Contributor Author

@WojciechMazur could we test if this fixes the issues still in #23664 (comment)?

@WojciechMazur
Copy link
Contributor

I've run the OpenCB, unfortunately project is still failing with the same errors as before https://github.com/VirtusLab/community-build3/actions/runs/16807072991/job/47603167918

It would great to minimize the issue first, but the code itself is non trivial - it uses quotes reflection to calculate expected result types for results of operations on units, eg. multiplication of 2 values of Meter typer results in result type Meter ^ 2 and also depends on another project for type refinements.

@EugeneFlesselle
Copy link
Contributor Author

I've run the OpenCB, unfortunately project is still failing with the same errors as before https://github.com/VirtusLab/community-build3/actions/runs/16807072991/job/47603167918

Too bad, it was worth a shot. Thanks for testing it out though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in typer for erikerlandson/coulomb
2 participants