-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[do not merge] Add capture checking annotation to Scala 3 Standard Library #23688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
natsukagami
wants to merge
25
commits into
scala:main
Choose a base branch
from
natsukagami:cc-no-emit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had the `ex.label eq label` comparision, which is no longer the case, with the (package) private label field.
Mostly imports here
…tuple match types Currently it's tripping up the cc phase
Just imports for now, no quotes support for capturing types yet
We need to split the files here, because... ?
Relies on scala#23695 to land on next base version
9ff8e6c
to
13a2ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
boundary
is now capture-checked, preventingLabel
from being leaked outside of its correspondingboundary
. Requires Makecaps.Capability
non-experimental #23507.Files missing capture checking
Tuple.scala
, waiting for Fix match type bounds checking problem #23695 to reach the next base versionMirror.scala
, which requires auto-generated Mirrors to be compatible with extending one of thecaps.Capability
subtraits. Currently the plan is to simply ban case classes.