Better printing of capabilities in error messages #23701
Merged
+299
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
better-cc-errors
branch
from
bf77442 to
e06d718
Compare
If the closure has an expected function type with a fully defined result type, take the internalized result type as the local return type of the closure. This has the effect that some conformance tests are now done with Fresh instead Result caps. This means a now can widen a local reference to a result cap, since the comparison is done between the local reference and the internalized FreshCap. Previously this failed since we compared a local cap with result cap, and result caps only subtype other result caps. It also propagates types more aggressively into closure bodies, which sometimes reduces the error span and improves the error message.
- Special case in some situations so that we only print the name, not the underlying type. - Print TermParamRefs like other singleton types
odersky
force-pushed
the
better-cc-errors
branch
from
e06d718 to
cce5762
Compare
natsukagami
reviewed
Aug 11, 2025
Comment on lines
-706
to
-713
| def levelOK = | ||
| if ccConfig.useFreshLevels && !CCState.collapseFresh then | ||
| val yOwner = y.levelOwner | ||
| yOwner.isStaticOwner || x.ccOwner.isContainedIn(yOwner) | ||
| else y.core match | ||
| case ResultCap(_) | _: ParamRef => false | ||
| case _ => true | ||
|
|
There was a problem hiding this comment.
This is a surprising removal, is it intended?
natsukagami
approved these changes
Aug 11, 2025
|
The removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not the underlying type.