Skip to content

Port generateSources to Scala 3 Library #23705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

natsukagami
Copy link
Contributor

The generators used in generateSources are copied over in the first commit, and changes to make them match the current source code is presented in the second commit.

This includes adding import scala.language.`2.13` into the generated sources.

It is added as a generateSources command inside scala-library-(non)boostrapped projects.

Note that the genprod file was renamed to GenerateLibraryNTemplates, but I still think the name is somewhat unclear. Suggestions welcomed.

@natsukagami natsukagami requested a review from a team as a code owner August 11, 2025 13:01
@natsukagami natsukagami changed the title Port generateSources to Dotty Port generateSources to Scala 3 Library Aug 11, 2025
Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few inline comments. Most of those relate to code style or comment consistency but I have some concerns about the logic of the function converters, which I found particularly difficult to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants