Skip to content

Conversation

natsukagami
Copy link
Contributor

@natsukagami natsukagami commented Aug 14, 2025

This PR consists of two commits:

  • The first one moves scala.Pure to scala.caps.Pure, updating all relevant references and tests
  • The second one drops @experimental, marking it stable in accordance with the status of scala.caps's other non-experimental symbols.

Pure has always been a capture-checking only class.

@natsukagami natsukagami marked this pull request as ready for review August 15, 2025 11:59
@natsukagami natsukagami requested a review from a team as a code owner August 15, 2025 11:59
@natsukagami natsukagami requested a review from bracevac August 15, 2025 11:59
|| isAllowed(defn.NonEmptyTupleClass, "Tuple.scala")
|| isAllowed(defn.PairClass, "Tuple.scala")
|| isAllowed(defn.PureClass, "Pure.scala"),
|| isAllowed(defn.PureClass, /* caps/ */ "Pure.scala"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment truly necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a reminder, since isAllowed only checks the file name and not the full path

@natsukagami natsukagami enabled auto-merge (rebase) August 15, 2025 12:20
@natsukagami natsukagami disabled auto-merge August 15, 2025 12:20
@natsukagami natsukagami enabled auto-merge August 15, 2025 12:21
@natsukagami natsukagami merged commit 25aadca into scala:main Aug 15, 2025
47 checks passed
@natsukagami natsukagami deleted the move-pure-to-caps branch August 15, 2025 21:30
@hamzaremmal hamzaremmal added the release-notes Should be mentioned in the release notes label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Should be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants