-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: release artifacts of the new build to the new repository #23761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Release Artifacts to Maven | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| environment: | ||
| required: true | ||
| type: string | ||
|
|
||
| jobs: | ||
| release-maven-artifacts: | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ inputs.environment }} | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'adopt' | ||
| java-version: 17 | ||
| cache: 'sbt' | ||
| - uses: sbt/setup-sbt@v1 | ||
| - name: Publish Artifacts to the Maven Repository | ||
| run : sbt scala3-bootstrapped-new/publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: Nightly Release of Scala 3 | ||
| run-name: Nightly Release of Scala 3 (${{ github.sha }}) | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 3 * * *' # Every day at 3 AM | ||
|
|
||
| jobs: | ||
|
|
||
| ## TODO: Add the compilation pipeline here | ||
|
|
||
| ## TODO: Add the test pipeline here | ||
|
|
||
| release-maven-artifacts: | ||
| # TODO: Add a dependency to the test ad compilation pipeline before releasing | ||
| uses: ./.github/workflows/release-maven-artifacts.yml | ||
| with: | ||
| environment: release-nightly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1471,6 +1471,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scala3-sbt-bridge:*.**.**-bootstrapped project */ | ||
| lazy val `scala3-sbt-bridge-bootstrapped` = project.in(file("sbt-bridge")) | ||
| .dependsOn(`scala3-compiler-bootstrapped-new`) // TODO: Would this actually evict the reference compiler in scala-tool? | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-sbt-bridge-bootstrapped", | ||
| moduleName := "scala3-sbt-bridge", | ||
|
|
@@ -1542,6 +1543,7 @@ object Build { | |
| // when compiling a project that depends on scala3-staging (see sbt-test/sbt-dotty/quoted-example-project), | ||
| // but we always need it to be present on the JVM classpath at runtime. | ||
| .dependsOn(`scala3-compiler-bootstrapped-new` % "provided; compile->runtime; test->test") | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-staging", | ||
| moduleName := "scala3-staging", | ||
|
|
@@ -1599,6 +1601,7 @@ object Build { | |
| // when compiling a project that depends on scala3-tasty-inspector (see sbt-test/sbt-dotty/tasty-inspector-example-project), | ||
| // but we always need it to be present on the JVM classpath at runtime. | ||
| .dependsOn(`scala3-compiler-bootstrapped-new` % "provided; compile->runtime; test->test") | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-tasty-inspector", | ||
| moduleName := "scala3-tasty-inspector", | ||
|
|
@@ -1737,6 +1740,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scala-library:*.**.**-bootstrapped project */ | ||
| lazy val `scala-library-bootstrapped` = project.in(file("library")) | ||
| .enablePlugins(ScalaLibraryPlugin) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala-library-bootstrapped", | ||
| moduleName := "scala-library", | ||
|
|
@@ -1809,6 +1813,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scala3-library_3:*.**.**-bootstrapped project */ | ||
| lazy val `scala3-library-bootstrapped-new` = project.in(file("library")) | ||
| .dependsOn(`scala-library-bootstrapped`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-library-bootstrapped", | ||
| moduleName := "scala3-library", | ||
|
|
@@ -1851,6 +1856,7 @@ object Build { | |
| // We add a dependency to the JVM library to have the classfile available | ||
| // (as they are not part of this artifact) | ||
| .dependsOn(`scala3-library-bootstrapped-new`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala-library-sjs", | ||
| organization := "org.scala-js", | ||
|
|
@@ -1961,6 +1967,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scala3-library_sjs1_3:*.**.**-bootstrapped project */ | ||
| lazy val `scala3-library-sjs` = project.in(file("library-js")) | ||
| .dependsOn(`scala-library-sjs`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-library-sjs", | ||
| moduleName := "scala3-library_sjs1", | ||
|
|
@@ -2064,6 +2071,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:tasty-core_3:*.**.**-bootstrapped project */ | ||
| lazy val `tasty-core-bootstrapped-new` = project.in(file("tasty")) | ||
| .dependsOn(`scala3-library-bootstrapped-new`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "tasty-core-bootstrapped", | ||
| moduleName := "tasty-core", | ||
|
|
@@ -2256,6 +2264,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scala3-compiler_3:*.**.**-bootstrapped project */ | ||
| lazy val `scala3-compiler-bootstrapped-new` = project.in(file("compiler")) | ||
| .dependsOn(`scala3-interfaces`, `tasty-core-bootstrapped-new`, `scala3-library-bootstrapped-new`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scala3-compiler-bootstrapped", | ||
| moduleName := "scala3-compiler", | ||
|
|
@@ -2390,6 +2399,7 @@ object Build { | |
| /* Configuration of the org.scala-lang:scaladoc_3:*.**.**-bootstrapped project */ | ||
| lazy val `scaladoc-new` = project.in(file("scaladoc")) | ||
| .dependsOn(`scala3-compiler-bootstrapped-new`, `scala3-tasty-inspector-new`) | ||
| .settings(publishSettings) | ||
| .settings( | ||
| name := "scaladoc", | ||
| moduleName := "scaladoc", | ||
|
|
@@ -3527,10 +3537,24 @@ object Build { | |
| publishMavenStyle := true, | ||
| isSnapshot := version.value.contains("SNAPSHOT"), | ||
| publishTo := { | ||
| val centralSnapshots = "https://central.sonatype.com/repository/maven-snapshots/" | ||
| if (isSnapshot.value) Some("central-snapshots" at centralSnapshots) | ||
| else localStaging.value | ||
| if (sys.env.get("NEWNIGHTLY").contains("yes")) { | ||
| Some(sys.env("MAVEN_REPOSITORY_REALM") at sys.env("MAVEN_REPOSITORY_URL")) | ||
| } else if (isSnapshot.value) { | ||
| Some("central-snapshots" at "https://central.sonatype.com/repository/maven-snapshots/") | ||
| } else | ||
| localStaging.value | ||
| }, | ||
| credentials ++= ( | ||
| if (sys.env.get("NEWNIGHTLY").contains("yes")) { | ||
| for { | ||
| username <- sys.env.get("MAVEN_REPOSITORY_USER") | ||
| token <- sys.env.get("MAVEN_REPOSITORY_TOKEN") | ||
| } yield Credentials(sys.env("MAVEN_REPOSITORY_REALM"), sys.env("MAVEN_REPOSITORY_HOST"), username, token) | ||
| } | ||
| else | ||
| // The old build credentials are configured differently | ||
| None | ||
| ).toList, | ||
| publishConfiguration ~= (_.withOverwrite(true)), | ||
| publishLocalConfiguration ~= (_.withOverwrite(true)), | ||
| projectID ~= {id => | ||
|
|
@@ -3539,76 +3563,8 @@ object Build { | |
| }, | ||
| Test / publishArtifact := false, | ||
| homepage := Some(url(dottyGithubUrl)), | ||
| licenses += (("Apache-2.0", | ||
| url("https://www.apache.org/licenses/LICENSE-2.0"))), | ||
| scmInfo := Some( | ||
| ScmInfo( | ||
| url(dottyGithubUrl), | ||
| "scm:git:[email protected]:scala/scala3.git" | ||
| ) | ||
| ), | ||
| developers := List( | ||
| Developer( | ||
| id = "odersky", | ||
| name = "Martin Odersky", | ||
| email = "[email protected]", | ||
| url = url("https://github.com/odersky") | ||
| ), | ||
| Developer( | ||
| id = "DarkDimius", | ||
| name = "Dmitry Petrashko", | ||
| email = "[email protected]", | ||
| url = url("https://d-d.me") | ||
| ), | ||
| Developer( | ||
| id = "smarter", | ||
| name = "Guillaume Martres", | ||
| email = "[email protected]", | ||
| url = url("http://guillaume.martres.me") | ||
| ), | ||
| Developer( | ||
| id = "felixmulder", | ||
| name = "Felix Mulder", | ||
| email = "[email protected]", | ||
| url = url("http://felixmulder.com") | ||
| ), | ||
| Developer( | ||
| id = "liufengyun", | ||
| name = "Liu Fengyun", | ||
| email = "[email protected]", | ||
| url = url("https://fengy.me") | ||
| ), | ||
| Developer( | ||
| id = "nicolasstucki", | ||
| name = "Nicolas Stucki", | ||
| email = "[email protected]", | ||
| url = url("https://github.com/nicolasstucki") | ||
| ), | ||
| Developer( | ||
| id = "OlivierBlanvillain", | ||
| name = "Olivier Blanvillain", | ||
| email = "[email protected]", | ||
| url = url("https://github.com/OlivierBlanvillain") | ||
| ), | ||
| Developer( | ||
| id = "biboudis", | ||
| name = "Aggelos Biboudis", | ||
| email = "[email protected]", | ||
| url = url("http://biboudis.github.io") | ||
| ), | ||
| Developer( | ||
| id = "allanrenucci", | ||
| name = "Allan Renucci", | ||
| email = "[email protected]", | ||
| url = url("https://github.com/allanrenucci") | ||
| ), | ||
| Developer( | ||
| id = "Duhemm", | ||
| name = "Martin Duhem", | ||
| email = "[email protected]", | ||
| url = url("https://github.com/Duhemm") | ||
| ) | ||
| ) | ||
| licenses += (("Apache-2.0", url("https://www.apache.org/licenses/LICENSE-2.0"))), | ||
| scmInfo := Some(ScmInfo(url(dottyGithubUrl), "scm:git:[email protected]:scala/scala3.git")), | ||
| ) | ||
|
|
||
| lazy val commonDistSettings = Seq( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change needed? The central sonatype where we would publish stable releases marks that
developersattribute are requiredhttps://central.sonatype.org/publish/requirements/#developer-information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it as most of the people there are not involved in the development of Scala anymore. I wasn't aware it was mandatory for the releases. I'll add it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that was the reason. The list might be modify to show the current state, or even better it could be potentially generated based on the
compiler/MAINTENANCE.mdmaintenance list section in the futureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking we could do this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that can also work, that's exactly what Kotlin does https://repo1.maven.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/2.2.0/kotlin-stdlib-2.2.0.pom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will use https://scala-lang.org too