Skip to content

fix(patmat): Add subtype-based fallback in inferPrefixMap and recalculate constraints after application #23771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

fix(patmat): Add subtype-based fallback in inferPrefixMap and recalculate constraints after application #23771

merged 1 commit into from
Sep 10, 2025

Conversation

nox213
Copy link
Contributor

@nox213 nox213 commented Aug 17, 2025 •
edited
Loading

fix #23369

  1. Add fallback logic in inferPrefixMap that uses subtype relationships to find a singleton when an exact match cannot be found
  2. Ensure that constraints are calculated after applying inferPrefixMap

nox213
nox213 commented Aug 17, 2025
View reviewed changes
@nox213
Copy link
Contributor Author

nox213 commented Aug 18, 2025

I will look into CI failure

@Gedochao Gedochao requested a review from noti0na1 August 27, 2025 11:21
@nox213 nox213 changed the title fix(patmat): Use childPrefix to resolve path-dependent sealed children fix(patmat): Add subtype-based fallback in inferPrefixMap and recalculate constraints after application Sep 2, 2025
@tgodzik
Copy link
Contributor

tgodzik commented Sep 9, 2025

@noti0na1 Are you able to take a look at this? The contributor pinged us on discord.

@noti0na1
Copy link
Member

noti0na1 commented Sep 9, 2025

Sure, I saw there were some new commits last week so I was not sure if the PR is completed or not.

noti0na1
noti0na1 reviewed Sep 9, 2025
View reviewed changes
noti0na1
noti0na1 requested changes Sep 9, 2025
View reviewed changes
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me! I will approve after the test is updated.

@nox213 nox213 requested a review from noti0na1 September 10, 2025 00:22
@nox213
Add subtype-based fallback in inferPrefixMap
4fd7a90 
add new line

second approach

revert previous approach

address reviews
@noti0na1 noti0na1 merged commit fc2244e into scala:main Sep 10, 2025
44 checks passed
@nox213 nox213 deleted the fix/i23369 branch September 17, 2025 05:24
@WojciechMazur WojciechMazur mentioned this pull request Sep 20, 2025
Merged
WojciechMazur added a commit that referenced this pull request Sep 22, 2025
@WojciechMazur
Backport "fix(patmat): Add subtype-based fallback in inferPrefixMap a…
9a3ca34 
…nd recalculate constraints after application" to 3.7.4 (#23995)

Backports #23771 to the 3.7.4.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.7.4 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

Assignees

@noti0na1 noti0na1

Labels

None yet

Projects

None yet

Milestone

3.7.4

Development

Successfully merging this pull request may close these issues.

No warning about non-exhaustive pattern matching for constructor with type bound enclosing type member

4 participants

@nox213 @tgodzik @noti0na1 @WojciechMazur