Fix false unreachable case warning #23800
Open
+61
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zielinsky
force-pushed
the
i20395_i20225
branch
from
bbf94cf to
c072b28
Compare
zielinsky
changed the title
zielinsky
changed the title
He-Pin
reviewed
Aug 24, 2025
zielinsky
force-pushed
the
i20395_i20225
branch
from
c072b28 to
700b08c
Compare
hamzaremmal
requested changes
Sep 3, 2025
There was a problem hiding this comment.
This should be moved to tests/pos.
There was a problem hiding this comment.
I think a test that no warnings are produced should be in tests/warn with -Werror to make plain that zero warnings are expected. That reserves pos for "successful compilation" (and avoids forgetting to add -Werror there). (I wish scala2 had warn tests to avoid pitfalls.) (I.e., tests/warn is not just for warnings behind -W flags, if that was the thinking, or only for tests that produce non-zero number of warnings.)
There was a problem hiding this comment.
This test too should be moved to tests/pos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow decomposition only on the right-hand side of a pattern if the type is not a type parameter, a type parameter reference, or a deferred type reference. This is because decomposition on the right-hand side of a pattern can lead to false positive warnings.
Fixes #20395
Fixes #20225