Replace pickling of sub matches with an annotation #23810
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s.t. the TastyFormat is unchanged Co-authored-by: Hamza Remmal <[email protected]>
|
This is not the usual modus operandi. What is calling for this change? There is nothing more permanent than a temporary solution. |
What would the modus operandi be (for an experimental feature in a new minor version)? scala3/compiler/src/dotty/tools/dotc/core/tasty/TreePickler.scala Lines 861 to 863 in ee2f641 |
|
The modus operandi is you just change the TASTy format to what you expect will look like the final version. That's why we have an experimental number in the TASTy version number. |
EugeneFlesselle
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 1, 2025
There was a discussion between the alternatives of: - modifying the tasty format, under the assumption that the tasty in question _should_ only be emitted in an experimental tasty version; - using an annotation to avoid changes to the tasty format. This PR implements the 1st option, see scala#23810 for the second option.
EugeneFlesselle
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 1, 2025
There was a discussion between the alternatives of: - modifying the tasty format, under the assumption that the tasty in question _should_ only be emitted in an experimental tasty version; - using an annotation to avoid changes to the tasty format. This PR implements the 1st option, see scala#23810 for the second option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.