- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.1k
 
Improve message for nested package missing braces #23816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve message for nested package missing braces #23816
Conversation
| 
           It looks like an error at EOF has a different line number when there is a newline at EOF.  | 
    
f380152    to
    5c42107      
    Compare
  
    | 
           Added a commit to move the caret at EOF if NL is at EOF. Offset of EOF was changed at 47f4e3f This commit doesn't revert that; it only tweaks the rendering; tools will still see the same  In particular, vulpix correlates diagnostic position with the line on which it sees  Note Scala 2 always ensured source content ended with NL; not sure how that interacted with REPL parsing.  | 
    
Move the caret closer to the real problem; clarify the error.
5c42107    to
    dab4466      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| 
           I hope the rendering diff is entirely benign; the test rig tweak is at least internal; and the nested package message is correct. For example, the following is not accepted ever:  | 
    
Move the caret closer to the real problem; clarify the error.
Fixes #23815