Skip to content

Fix derivesFrom false negative in provablyDisjointClasses #23834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2025
Merged

Fix derivesFrom false negative in provablyDisjointClasses #23834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5975a06
Fix `derivesFrom` false negative in `provablyDisjointClasses`
EugeneFlesselle Aug 28, 2025
43af511
Close #17132 as neg test
EugeneFlesselle Aug 28, 2025
470be47
Use more `mayDeriveFrom` where appropriate in `provablyDisjoint`
EugeneFlesselle Aug 28, 2025
546fbd1
Address review comments
EugeneFlesselle Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions compiler/src/dotty/tools/backend/jvm/CodeGen.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ class CodeGen(val int: DottyBackendInterface, val primitives: DottyPrimitives)(
case ex: InterruptedException => throw ex
case ex: CompilationUnit.SuspendException => throw ex
case ex: Throwable =>
ex.printStackTrace()
report.error(s"Error while emitting ${unit.source}\n${ex.getMessage}", NoSourcePosition)
report.error(s"Error while emitting ${unit.source}\n${ex.getMessage}", cd.sourcePos)


def genTastyAndSetAttributes(claszSymbol: Symbol, store: ClassNode): Unit =
Expand Down
11 changes: 11 additions & 0 deletions tests/neg/i17132.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

sealed trait Transformation[T]

case object Count extends Transformation[Int]
case class MultiTransformation[T1 <: Transformation[?], T2 <: Transformation[?]](t1: T1, t2: T2) // error cyclic
extends Transformation[MultiTransformationResult[T1, T2]]

type MultiTransformationResult[T1 <: Transformation[?], T2 <: Transformation[?]] <: Tuple = (T1, T2) match {
case (Transformation[t], MultiTransformation[t1, t2]) => t *: MultiTransformationResult[t1, t2]
case (Transformation[t1], Transformation[t2]) => (t1, t2)
}