Lint function arrow intended context function #23847
Open
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Sep 2, 2025
| @@ -168,6 +168,7 @@ private sealed trait WarningSettings: | |||
| private val WunstableInlineAccessors = BooleanSetting(WarningSetting, "WunstableInlineAccessors", "Warn an inline methods has references to non-stable binary APIs.") | |||
| private val WtoStringInterpolated = BooleanSetting(WarningSetting, "Wtostring-interpolated", "Warn a standard interpolator used toString on a reference type.") | |||
| private val WrecurseWithDefault = BooleanSetting(WarningSetting, "Wrecurse-with-default", "Warn when a method calls itself with a default argument.") | |||
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wdubious-contextual", "Warn about T ?=> (t: T) => U.") | |||
There was a problem hiding this comment.
Suggested change
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wdubious-contextual", "Warn about T ?=> (t: T) => U.") | |
| private val WunlikelyContextual = BooleanSetting(WarningSetting, "Wunlikely-contextual", "Warn about T ?=> (t: T) => U. when a normal function literal was used instead of context one."), |
just because the word is prone to typos for non english speakers and a bit more explanation aside from signature?
There was a problem hiding this comment.
I rely on -Xlint or now -Wall. Though I do like the word "dubious". All warnings are dubious because they begin with -W or "dubya".
| object Zone: | ||
| inline def apply[T](inline f: Zone ?=> T): T = f(using new Zone) | ||
|
|
||
| inline def zone[A](inline f: Zone ?=> A) = Zone.apply(z => f(using z)) // warn suspicious contextualizing |
There was a problem hiding this comment.
Will this be reported with:
def zone[A](f: Zone ?=> A) = Zone.apply(z => f(using z))
as well? Maybe the warning should only be for the inline cases, where it might cause most issues.
What do you think?
There was a problem hiding this comment.
I think it's the same issue, which is that the function literal is wrapped in a context function. I added it to the test to document the behavior is the same.
som-snytt
force-pushed
the
issue/21187-contextual-func-lit
branch
from
4684bed to
f1d5ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21187
If a function literal
x => bodyhas an expected typeX ?=> ?then maybe they intended to writex ?=> body.As shown in the test, maybe types will misalign in other ways to emit warnings.