Fix global init checker unexpected by name #23859
Merged
+22
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
approved these changes
Sep 2, 2025
| @@ -6,6 +6,6 @@ object Test: | |||
| class Box(val x: Int) | |||
|
|
|||
| def recur(a: => Box, b: => Box): Int = | |||
| a.x + recur(a: @widen(5), b: @widen(5)) + b.x // warn // warn | |||
| a.x + recur(a: @widen(5), b: @widen(5)) + b.x | |||
|
|
|||
| recur(Box(1), Box(2)) | |||
There was a problem hiding this comment.
We can drop this test, it's the same as the other one. The widen annotation does not have a meaning in the new analysis anymore.
There was a problem hiding this comment.
Since we still have the annotation, we can keep the test in case we start using the annotation again.
If we decide to remove the annotation at some point, we can have a PR that changes all the tests that use the annotation.
olhotak
approved these changes
Sep 2, 2025
| @@ -6,6 +6,6 @@ object Test: | |||
| class Box(val x: Int) | |||
|
|
|||
| def recur(a: => Box, b: => Box): Int = | |||
| a.x + recur(a: @widen(5), b: @widen(5)) + b.x // warn // warn | |||
| a.x + recur(a: @widen(5), b: @widen(5)) + b.x | |||
|
|
|||
| recur(Box(1), Box(2)) | |||
There was a problem hiding this comment.
Since we still have the annotation, we can keep the test in case we start using the annotation again.
If we decide to remove the annotation at some point, we can have a PR that changes all the tests that use the annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of throwing unexpected by name error in the global object initialization error when the by-name value is a modelled by set of
Fun. Each element in the value set is recursively evaluated