-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revert "Revert "Disable distribution of intersection types over applied types"" #23923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Disable distribution of intersection types over applied types"" #23923
Conversation
a5ec473
to
4d2442b
Compare
@hamzaremmal all ci-checks (including |
+CC[X] <: SortedSet[X] with SortedSetOps[X, CC, CC[X]], | ||
+WithFilterCC[x] <: IterableOps[x, WithFilterCC, WithFilterCC[x]] with Set[x]] extends SortedSetOps[A @uncheckedVariance, CC, CC[A @uncheckedVariance]] { | ||
self: IterableOps[A, WithFilterCC, _] => | ||
self: IterableOps[A, WithFilterCC, CC[A @uncheckedVariance]] => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked both changes here with @sjrd and they should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the PR as I had doubt over this change and it was breaking everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm getting the following, but in unclear situations (clean build worked; recompiled with a clean scala3-libary-nonbootstrapped
does not work).
[error] -- [E046] Cyclic Error: /localhome/doeraene/projects/dotty/library/src/scala/collection/Iterable.scala:992:11
[error] 992 | +CC[X] <: SortedSet[X] with SortedSetOps[X, CC, CC[X]],
[error] | ^
[error] | Cyclic reference involving trait SortedSet
[error] |
[error] | Run with -explain-cyclic for more details.s
[error] |
[error] | longer explanation available when compiling with `-explain`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, no, cleaning the library project fixes it. But still, it means it's appearing under some separate/incremental compilation scenarios. :s
It was a bad interaction with the build cache. I went ahead and completely disable it in the meantime. |
Reverts #23920