When unpickling, do not incorrectly set PureInterface flags #23944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the behavior for setting `NoInits` and `PureInterface` flags for class symbols in `TreeInfo.defKind` (when compiling from a source) and in `TreeUnpickler` (when reading Tasty) was inconsistent. This was problematic, as the `PureInterface` flag dictated whether outer accessors were generated in `ExplicitOuter` phase (in the `needsOuterIfReferenced` method), so in the issue minimization, the inherited trait would have the outer accessors defined, and the inheriting object would then not implement them. This lead to runtime `MethodNotFound` errors. The problem was specifically with lazy vals, which were treated as if they did not have an rhs.
|
This seems to be #23788 |
|
@som-snytt You are right, even the minimisation is basically the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the behavior for setting
NoInitsandPureInterfaceflags for class symbols inTreeInfo.defKind(when compiling from a source) and inTreeUnpickler(when reading Tasty) was inconsistent. This was problematic, as thePureInterfaceflag dictated whether outer accessors were generated inExplicitOuterphase (in theneedsOuterIfReferencedmethod), so in the issue minimization, the inherited trait would have the outer accessors defined, and the inheriting object would then not implement them. This lead to runtimeMethodNotFounderrors.The problem was specifically with lazy vals, which were treated as if they did not have an rhs.
Fixes #23863
I've added an additional test case also testing the same adjusted method in the TreeUnpickler, as I've run into an issue with nested objects when testing a previous incorrect fix on the original linked minimisation with external dependencies (and no compiler tests would fail).