Suppression matches inlined positions #24092
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inlined stack includes the nonInlined pos itself, which is filtered by rendering.
Fixes #24082
Why was the ticket worth tackling?
Local warning suppression must work with inlining. Otherwise, users must choose whether to forego warnings (which are an optional feature) or inlining (which may not be optional for a particular use case).
How I fixed it
How does
@nowarn
know what to suppress? ASuppression
is registered with the currentRun
, and when reporting, aSuppression
matches
a given diagnostic based on position. The diagnostic position knows its "enclosing" inlined positions, so a suppression should also match those positions.Why is this PR worth reviewing?
It's a one-liner that enables important feature interop.
What's the worse that could happen?
It can only suppress additional diagnostics, so at worst it results in false negatives, which are preferable to the alternative.