Trap Ctrl-C in the REPL: if no command is running clear the prompt, if some command is running ask for confirmation before exiting #24127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports over one of the other Ammonite features to the Scala 3 REPL, making it behave much more similarly to other prompt environment (Bash, Python, etc.):
Ctrl-C
just resets the prompt without exitingCtrl-C
first interrupts the thread to try and force a gentle exit. A secondCtrl-C
would then terminate the process.Unfortunately we will no longer be able to terminate the thread forcefully, as
Thread.stop
is busted Java >20 (see com-lihaoyi/Ammonite#1379), so usingThread.interrupt
andsys.exit
is the best we haveTested manually using
bin/scala
. Doesn't work insbt repl
due to SBT also intercepting the signal, but that's a separate issue we can follow up later