Fluidify explicit self types for non-CC classes#25639
Open
Linyxus wants to merge 3 commits intoscala:mainfrom
Open
Fluidify explicit self types for non-CC classes#25639Linyxus wants to merge 3 commits intoscala:mainfrom
Linyxus wants to merge 3 commits intoscala:mainfrom
Conversation
odersky
requested changes
Mar 28, 2026
odersky
requested changes
Mar 28, 2026
| private def fluidify(using Context) = new TypeMap: | ||
| def apply(t: Type): Type = t match | ||
| case cinfo: ClassInfo => | ||
| val selfInfo1: TypeOrSymbol = cinfo.selfInfo match |
Contributor
There was a problem hiding this comment.
You can use givenSelfTyoe here to simplify the logic.
Contributor
Author
There was a problem hiding this comment.
Fixed. I wasn't aware of this helper! Thanks.
... and use the beautiful colon syntax. So elegant.
Contributor
Author
|
@odersky ping for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25634.
How much have you relied on LLM-based tools in this contribution?
I used GPT-5.4 to pinpoint the root and produce a fix.
How was the solution tested?
Human eyes and
testCompilation.Additional notes