Delay normalization of capture sets of vals and defs#25640
Merged
odersky merged 4 commits intoscala:mainfrom Mar 28, 2026
Merged
Delay normalization of capture sets of vals and defs#25640odersky merged 4 commits intoscala:mainfrom
odersky merged 4 commits intoscala:mainfrom
Conversation
Normalization means: Make all LocalCaps of a val or def `sym` have origin InDecl(sym). Previously this was done immediately when an element was included in a set. But that broke transaction semantics since dome additions could not be undone by removing the added element from the set. We now do the same transformation as part of interpolation after the definition is rechecked. This is still OK, since the normalization is needed only for separation checking. Fixes scala#25622
Contributor
|
Is this ready to be merged? Everything looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalization means: Make all LocalCaps of a val or def
symhaveorigin InDecl(sym). Previously this was done immediately when an
element was included in a set. But that broke transaction semantics
since some additions could not be undone by removing the added element
from the set. We now do the same transformation as part of interpolation
after the definition is rechecked.
This is still OK, since the normalization is needed only for separation
checking
Fixes #25622