basic design implemented in Golang #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyammittal
reviewed
May 6, 2020
static/example.html
Outdated
|
|
||
| if (window.console==null) { window["console"] = { log : function() {} } }; // some browsers do not set console | ||
|
|
||
| var Application = function() { |
There was a problem hiding this comment.
Can we separate javascript in separate folder.
There was a problem hiding this comment.
static/js/ folder would be fine
|
for now you can keep the title: "Chatbot Sharing Portal" |
satyammittal
requested changes
May 6, 2020
|
We had made the design in adobe XD. Adobe XD has a web export plugin which creates a basic html template. The code in chatbot.js has been generated using that. |
satyammittal
requested changes
May 6, 2020
There was a problem hiding this comment.
2 suggestions:
a) Can we go with some web framework like gin-gonic?
b) also we can separate content with markdown files: https://jonathanmh.com/creating-simple-markdown-blog-go-gin/
|
Okay! We will look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.