Skip to content

Conversation

GargiVyas31
Copy link

No description provided.

@pep8speaks
Copy link

pep8speaks commented Mar 29, 2020

Hello @GargiVyas31! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-16 17:42:25 UTC

chatbot.py Outdated
translate = input("Type: ").lower()
translate = translate.translate(table)
translate = spell.correction(translate)
# print(translate)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the usecase of comment statement. can it notify user when wrong spell.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gargi, Any update on this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented statement was to check if the pyspellchecker object accurately corrects the misspelled words. Yes, we can uncomment it and show the user the corrected statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can you remove this or put a comment regarding explaining how it works. #print looks like a debug statement.

@satyammittal
Copy link
Member

@GargiVyas31 Please fix the pep8 issues.

@GargiVyas31 GargiVyas31 reopened this Apr 16, 2020
@GargiVyas31
Copy link
Author

I can't see any issues. The branch has no issues. Pls check.

@satyammittal
Copy link
Member

Issues are listed here: #48 (comment)

'Edward', 'Some_guy_whom_i_never_got_to_know.']
var3 = ['what time is it', 'what is the time', 'time']
var4 = ['who are you', 'what is you name']
var5 = ['date', 'what is the date', 'what date is it', 'tell me the date']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is removed? what about then user ask for date.

@gautamig54
Copy link

Hi! I tried using the pyspellchecker library for autocorrecting the words. It did not work effectively for me. Eg. When I typed "how ar you?", it returned me the incorrect work as "you?" and suggested "you". It did not consider "ar". I think the library provided a provision to customise the spell check. We need to upload a text file, containing the customised input to the chatbot and correct the user input accordingly.
Or you can try hunspell library which works better that pyspellchecker.
Great work!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants