Skip to content

[Blocked] Make creating virtual datasets on publish/upload optional#9254

Draft
fm3 wants to merge 5 commits intomasterfrom
virtual-optional
Draft

[Blocked] Make creating virtual datasets on publish/upload optional#9254
fm3 wants to merge 5 commits intomasterfrom
virtual-optional

Conversation

@fm3
Copy link
Copy Markdown
Member

@fm3 fm3 commented Jan 29, 2026

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

TODOs:

  • Upload
    • forbid layers to link
  • UploadToPaths
    • create as virtual first, set non-virtual on finish? or is the pending attribute enough?
    • leave out datasource in response, instead return just path in binaryData
    • in this case the libs create single symlink (or copy/move according to transfer mode)
    • libs still need commonStoragePrefix (it’s the binaryData folder now)
      • trouble: if the source dataset doesn’t have symlinks but just paths, it stays that way
    • but it can be removed from the protocol with webknossos! → follow-up
  • ExploreAndAdd
    • can still create virtual, yolo
  • Compose
  • DuplicateToOrga
    • can still create virtual, yolo
  • in dataset settings view, show directory name for non-virtual

2h40m

Issues:

  • fixes #

(Please delete unneeded items, merge only when none are left open)

  • Added changelog entry (create a $PR_NUMBER.md file in unreleased_changes or use ./tools/create-changelog-entry.py)
  • Added migration guide entry if applicable (edit the same file as for the changelog)
  • Updated documentation if applicable
  • Adapted wk-libs python client if relevant API parts change
  • Removed dev-only changes like prints and application.conf edits
  • Considered common edge cases
  • Needs datastore update after deployment

@fm3 fm3 self-assigned this Jan 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch virtual-optional

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fm3 fm3 changed the title Make creating virtual datasets optional Make creating virtual datasets on publish/upload optional Feb 2, 2026
@fm3 fm3 changed the title Make creating virtual datasets on publish/upload optional [Blocked] Make creating virtual datasets on publish/upload optional Feb 10, 2026
@fm3
Copy link
Copy Markdown
Member Author

fm3 commented Feb 10, 2026

Blocked by open discussion

@fm3 fm3 added the discussion label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant