Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughTightened Node engine to >=22.12.0, updated Vite and related devDependencies, added Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
14-37:⚠️ Potential issue | 🟠 MajorResolve peer dependency mismatch between plugin-react and plugin-babel.
@vitejs/plugin-react@^6.0.0specifies@rolldown/plugin-babel@^0.1.7as a peer dependency, but the package.json declares@rolldown/plugin-babel@^0.2.1. This creates an unmet peer dependency that will cause npm install warnings or resolution failures.Upgrade
@vitejs/plugin-reactto^6.0.1, which updates the peer range to^0.1.7 || ^0.2.0.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 14 - 37, Update the `@vitejs/plugin-react` dependency version to ^6.0.1 in package.json so its peer range includes `@rolldown/plugin-babel` ^0.2.0; specifically change the "@vitejs/plugin-react" entry (which currently is "^6.0.0") to "^6.0.1" to resolve the peer dependency mismatch with "@rolldown/plugin-babel" and then reinstall dependencies.
🧹 Nitpick comments (1)
vite.config.ts (1)
45-49: Setbuild.copyPublicDirexplicitly tofalsewhen outputting topublic.Line 46 sets
outDir: "public", which overlaps with Vite's defaultpublicDir. By default, Vite 8 enablescopyPublicDir: true, causing it to copypublicDirintooutDir, resulting in a self-copy edge case and warnings about non-separate folders. Explicitly disabling this avoids the unnecessary copy and warnings.♻️ Proposed config tweak
build: { outDir: "public", // note: /public is handled by the backend/Play framework for asset delivery emptyOutDir: true, + copyPublicDir: false, sourcemap: true, rolldownOptions: {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@vite.config.ts` around lines 45 - 49, Set build.copyPublicDir to false in the Vite config to prevent Vite from copying the publicDir into outDir when outDir is "public"; update the build block (where outDir: "public", emptyOutDir, sourcemap, and rolldownOptions are defined) to include copyPublicDir: false so the build doesn't attempt the self-copy/warnings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 59: Update the Node engine constraint in package.json so it excludes Node
versions 22.0–22.11; specifically change the "engines.node" value (currently
">=22") to ">=22.12.0" so Vite 8 and `@vitejs/plugin-react` 6 are guaranteed
compatible.
---
Outside diff comments:
In `@package.json`:
- Around line 14-37: Update the `@vitejs/plugin-react` dependency version to
^6.0.1 in package.json so its peer range includes `@rolldown/plugin-babel` ^0.2.0;
specifically change the "@vitejs/plugin-react" entry (which currently is
"^6.0.0") to "^6.0.1" to resolve the peer dependency mismatch with
"@rolldown/plugin-babel" and then reinstall dependencies.
---
Nitpick comments:
In `@vite.config.ts`:
- Around line 45-49: Set build.copyPublicDir to false in the Vite config to
prevent Vite from copying the publicDir into outDir when outDir is "public";
update the build block (where outDir: "public", emptyOutDir, sourcemap, and
rolldownOptions are defined) to include copyPublicDir: false so the build
doesn't attempt the self-copy/warnings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6b36eb90-2cf5-40be-9bab-e86601426a21
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
package.jsonvite.config.ts
1 participant
vitest(and@vitest/coverage-v8) to v4.1. to match.@vitejs/plugin-reactto v6 to match. The plugin was also migrated to use new Rust-basedvitetoolchain (oxc) and dropsbabel. Babel, however, is a requirements for the React compiler (and slow). I added the suggested config from their release notes: https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%406.0.0JSX.Elementby either removing the type hint (automatic inference) or replacement withReact.ReactElementreact-markdownto version 10 to fix type error withJSXtypesyarn dedupeto eliminate duplicate versions of packagesURL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)
$PR_NUMBER.mdfile inunreleased_changesor use./tools/create-changelog-entry.py)