Skip to content

Fix bug where initial proofreading split action failed #9412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelBuessemeyer merged 4 commits into from
Mar 23, 2026
+5 −1
Merged

Fix bug where initial proofreading split action failed #9412

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d103d09
Fix bug where initial proofreading action had outdated annotation ver…
MichaelBuessemeyer Mar 23, 2026
4002172
add changelog entry
MichaelBuessemeyer Mar 23, 2026
7a77a7a
fix grammer
MichaelBuessemeyer Mar 23, 2026
3b72c1f
Update unreleased_changes/9412.md
MichaelBuessemeyer Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/javascripts/viewer/model/sagas/volume/proofread_saga.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,6 @@ type Preparation = {

function* prepareSplitOrMerge(isSkeletonProofreading: boolean): Saga<Preparation | null> {
const volumeTracingLayer = yield* select((state) => getActiveSegmentationTracingLayer(state));
const annotationVersion = yield* select((state) => state.annotation.version);
const volumeTracing = yield* select((state) => getActiveSegmentationTracing(state));
if (volumeTracingLayer == null || volumeTracing == null) {
return null;
Expand Down Expand Up @@ -1410,6 +1409,9 @@ function* prepareSplitOrMerge(isSkeletonProofreading: boolean): Saga<Preparation
return null;
}

// Getting latest annotation version as it might have changed due to e.g. making the mapping editable.
const annotationVersion = yield* select((state) => state.annotation.version);

Comment on lines +1412 to +1414
Copy link
Copy Markdown
Contributor Author

@MichaelBuessemeyer MichaelBuessemeyer Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is easy: Load the annotation version !after! the mapping was potentially made editable (which changes the version).

The returned annotationVersion of this function as later used in the sagas handling split operations. On the master the version before making the mapping editable was returned.
=> This lead to the proofreading sagas requesting edges to split with an annotation version, where the version was actually lower than the version where it was made editable. Thus, the server correctly replied with an error.

=> Moving the select "lower" in the function fixed the bug easily

return {
agglomerateFileMag,
getDataValue,
Expand Down
2 changes: 2 additions & 0 deletions unreleased_changes/9412.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Fixed
- Fixed a bug where the initial operation of a proofreading annotation failed if it is split action.
Loading