Include provided dependencies in bloop runtime classpath #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #2235 by including Provided dependencies in the runtime classpath when exporting sbt builds to bloop, aligning runtime execution behavior with JVM semantics.
- Modified
emulateRuntimeDependencyClasspathto include dependencies with Provided scope - Added a new scripted test to verify Provided dependencies are available at runtime
- Used
.distinctto handle potential duplicate entries in the classpath
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integrations/sbt-bloop/src/main/scala/bloop/integrations/sbt/SbtBloop.scala | Modified emulateRuntimeDependencyClasspath to fetch and include Provided scope dependencies in the runtime classpath, with deduplication |
| integrations/sbt-bloop/src/sbt-test/sbt-bloop/provided-runtime-classpath/build.sbt | Test configuration that defines a project with a Provided dependency and assertions to verify it appears in both compile and runtime classpaths |
| integrations/sbt-bloop/src/sbt-test/sbt-bloop/provided-runtime-classpath/project/plugins.sbt | Configures the sbt-bloop plugin for the test project |
| integrations/sbt-bloop/src/sbt-test/sbt-bloop/provided-runtime-classpath/test | Scripted test script that runs bloopGenerate and checkBloopFiles tasks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tgodzik
requested changes
Jan 8, 2026
Contributor
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Looks like the project is not building. Could you take a look?
Contributor
Author
|
@tgodzik I wasn’t able to reliably run scripted locally in Codespaces due to sbt session initialization issues, but the change is minimal and scoped. CI should give a clean signal — happy to iterate based on CI failures if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2235
This change includes Provided dependencies in the runtime classpath when
exporting sbt builds to bloop.
This fixes bloop run and local debugging behavior by aligning runtime execution
with JVM semantics.
A new scripted test verifies that a Provided dependency is available at runtime.