Skip to content

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Aug 18, 2025

No description provided.

import Bool._
def day(d: Day.Value): Unit = ???
val d =
val d: test.explicitResultTypes.EnumerationValue.Day.Value =
Copy link
Collaborator Author

@bjaglin bjaglin Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up of https://github.com/scalacenter/scalafix/pull/2227/files#r2076245745

scala/scala3#23124 brings

  • valid type annotations for 3.7.x target back (regression from 3.7.0 to 3.7.1)
  • consideration of the import Bool._ above for shortening, an improvement over 3.7.0 & 3.3.x which always used the FQDN as documented in
    import Bool._
    def day(d: Day.Value): Unit = ???
    val d: test.explicitResultTypes.EnumerationValue.Day.Value =
    if (true) Day.Weekday
    else Day.Weekend
    day(d)
    val b: test.explicitResultTypes.EnumerationValue.Bool.Value =
    if (true) True
    else False

@@ -0,0 +1,24 @@
/*
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this is an exact copy of the scala-2 and scala-3lts file - it's unfortunate but having it DRyed in scala or scala-3 would trigger a failure for non-LTS, non-next version for which we have nowhere to define an output file (since we scala-3lts and scala-3next are different, we can't have one in scala-3)

@bjaglin bjaglin marked this pull request as ready for review August 18, 2025 17:56
@bjaglin bjaglin merged commit 221835b into scalacenter:main Aug 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant