BestFirstSearch: relax cost check w/ optimal token#4854
Open
kitbellew wants to merge 2 commits intoscalameta:mainfrom
Open
BestFirstSearch: relax cost check w/ optimal token#4854kitbellew wants to merge 2 commits intoscalameta:mainfrom
kitbellew wants to merge 2 commits intoscalameta:mainfrom
Conversation
Rather than requiring that state cost remain unchanged with the latest split, let's limit it to checking that the original cost of the split (before any penalties may have been applied) is zero, and that the state does not overflow. This leads to extremely rare formatting changes (none on scala, spark, scalafmt, scalameta repos) and on average over a 5% improvement in the BestFirstSearch algorithm efficiency. This approach protects optimal-token intentions from penalties which are designed to rank different states, and is a follow-on to scalameta#4851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than requiring that state cost remain unchanged with the latest split, let's limit it to checking that the original cost of the split (before any penalties may have been applied) is zero, and that the state does not overflow.
This leads to extremely rare formatting changes (none on scala, spark, scalafmt, scalameta repos) and on average over a 5% improvement in the BestFirstSearch algorithm efficiency.
This approach protects optimal-token intentions from penalties which are designed to rank different states, and is a follow-on to #4851.