Skip to content

Conversation

@josh-wong
Copy link
Member

Description

This PR applies a white background to .png files when in dark mode. A background needs to be applied because if the background is transparent, some of the text is difficult to see when in dark mode.

Related issues and/or PRs

N/A

Changes made

  • Added a style in custom.css that applies a background to .png files within the .container style.
    • If we don't specify the .container style, a white background will be applied to the product logo in the top left-hand corner of the docs site, which is not what we want.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have updated the side navigation as necessary.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@josh-wong josh-wong added the bugfix Fix that resolves bugs label Apr 17, 2025
@josh-wong josh-wong self-assigned this Apr 17, 2025
@josh-wong josh-wong merged this pull request into main Apr 17, 2025
1 check passed
@josh-wong josh-wong deleted the docusaurus/add-background-to-transparent-images branch April 17, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix that resolves bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant