-
Notifications
You must be signed in to change notification settings - Fork 1
Add TLS support to the Scalar Manager Helm chart #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thongdk8
wants to merge
7
commits into
main
Choose a base branch
from
feat/sm-tls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
28a94de
Add TLS support for scalar manager
thongdk8 cbcbce7
apply suggestion
thongdk8 4eee391
WIP
thongdk8 447071b
Improve chart to support namespace aware config
thongdk8 3398c43
remove trailing space
thongdk8 ea6023b
simplify config
thongdk8 6b27307
formating
thongdk8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
charts/scalar-manager/templates/scalar-manager/certmanager.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| {{- if and .Values.scalarManager.tls.downstream.enabled .Values.scalarManager.tls.certManager.enabled }} | ||
| {{- if .Values.scalarManager.tls.certManager.selfSigned.enabled }} | ||
| {{- if eq .Values.scalarManager.tls.certManager.selfSigned.type "ca" }} | ||
| --- | ||
| # This issuer is for creating the self-signed CA certificate. | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Issuer | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-bootstrap-selfsigned-issuer | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| selfSigned: {} | ||
| --- | ||
| # This is the CA certificate. | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-ca-cert | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| isCA: true | ||
| commonName: {{ include "scalar-manager.fullname" . }}-ca | ||
| secretName: {{ include "scalar-manager.fullname" . }}-ca-cert | ||
| duration: {{ .Values.scalarManager.tls.certManager.duration }} | ||
| renewBefore: {{ .Values.scalarManager.tls.certManager.renewBefore }} | ||
| privateKey: | ||
| algorithm: {{ .Values.scalarManager.tls.certManager.privateKey.algorithm }} | ||
| encoding: {{ .Values.scalarManager.tls.certManager.privateKey.encoding }} | ||
| size: {{ .Values.scalarManager.tls.certManager.privateKey.size }} | ||
| issuerRef: | ||
| name: {{ include "scalar-manager.fullname" . }}-bootstrap-selfsigned-issuer | ||
| kind: Issuer | ||
| --- | ||
| # This issuer uses the CA certificate to sign other certificates. | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Issuer | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-ca-issuer | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| ca: | ||
| secretName: {{ include "scalar-manager.fullname" . }}-ca-cert | ||
| {{- else }} | ||
| --- | ||
| # This is a self-signed issuer for non-CA self-signed certificates. | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Issuer | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-self-signed-issuer | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| selfSigned: {} | ||
| {{- end }} | ||
| {{- end }} | ||
| --- | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| name: {{ include "scalar-manager.fullname" . }}-tls-cert | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| secretName: {{ include "scalar-manager.fullname" . }}-tls-cert | ||
| commonName: {{ include "scalar-manager.fullname" . }} | ||
| {{- with .Values.scalarManager.tls.certManager.dnsNames }} | ||
| dnsNames: | ||
| {{- range . }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| duration: {{ .Values.scalarManager.tls.certManager.duration }} | ||
| renewBefore: {{ .Values.scalarManager.tls.certManager.renewBefore }} | ||
| {{- with .Values.scalarManager.tls.certManager.usages }} | ||
| usages: | ||
| {{- range . }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| privateKey: | ||
| algorithm: {{ .Values.scalarManager.tls.certManager.privateKey.algorithm }} | ||
| encoding: {{ .Values.scalarManager.tls.certManager.privateKey.encoding }} | ||
| size: {{ .Values.scalarManager.tls.certManager.privateKey.size }} | ||
| issuerRef: | ||
| {{- if .Values.scalarManager.tls.certManager.selfSigned.enabled }} | ||
| {{- if eq .Values.scalarManager.tls.certManager.selfSigned.type "ca" }} | ||
| name: {{ include "scalar-manager.fullname" . }}-ca-issuer | ||
| {{- else }} | ||
| name: {{ include "scalar-manager.fullname" . }}-self-signed-issuer | ||
| {{- end }} | ||
| kind: Issuer | ||
| {{- else }} | ||
| {{- if not (len .Values.scalarManager.tls.certManager.issuerRef) }} | ||
| {{- fail "When using cert-manager with an external issuer, scalarManager.tls.certManager.issuerRef must be configured." -}} | ||
| {{- end }} | ||
| {{- toYaml .Values.scalarManager.tls.certManager.issuerRef | nindent 4 }} | ||
| {{- end }} | ||
| {{- end }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.