Skip to content

Conversation

@brfrn169
Copy link
Contributor

@brfrn169 brfrn169 commented Jun 24, 2025

Description

This PR adds support for the READ-COMMITTED isolation introduced by scalar-labs/scalardb#2803.

Related issues and/or PRs

Changes made

  • Fixed the validation for the isolation level.
  • Added a string conversion for the isolation level.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@brfrn169 brfrn169 self-assigned this Jun 24, 2025
@brfrn169 brfrn169 added the enhancement New feature or request label Jun 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the CLI runner to accept a new READ-COMMITTED isolation level, updating validation logic accordingly.

  • Added :read-committed to the allowed isolation levels
  • Updated the validation error message to list the new option
Comments suppressed due to low confidence (2)

scalardb/src/scalardb/runner.clj:118

  • Consider updating the user-facing documentation or README to mention the new read-committed option so that users see the supported isolation levels in all usage guides.
    :validate [#{:read-committed :snapshot :serializable}

scalardb/src/scalardb/runner.clj:118

  • There are no existing tests covering the read-committed isolation level for the CLI runner; adding a unit or integration test will ensure this new option is recognized and handled correctly.
    :validate [#{:read-committed :snapshot :serializable}

@brfrn169 brfrn169 requested review from feeblefakie and yito88 June 26, 2025 01:58
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit dc34595 into master Jun 27, 2025
4 checks passed
@feeblefakie feeblefakie deleted the support-read-committed-isolation branch June 27, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants