-
Notifications
You must be signed in to change notification settings - Fork 5
Support READ-COMMITTED isolation #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends the CLI runner to accept a new READ-COMMITTED isolation level, updating validation logic accordingly.
- Added
:read-committedto the allowed isolation levels - Updated the validation error message to list the new option
Comments suppressed due to low confidence (2)
scalardb/src/scalardb/runner.clj:118
- Consider updating the user-facing documentation or README to mention the new
read-committedoption so that users see the supported isolation levels in all usage guides.
:validate [#{:read-committed :snapshot :serializable}
scalardb/src/scalardb/runner.clj:118
- There are no existing tests covering the
read-committedisolation level for the CLI runner; adding a unit or integration test will ensure this new option is recognized and handled correctly.
:validate [#{:read-committed :snapshot :serializable}
yito88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR adds support for the
READ-COMMITTEDisolation introduced by scalar-labs/scalardb#2803.Related issues and/or PRs
Changes made
Checklist
Additional notes (optional)
N/A