Skip to content

Conversation

@brfrn169
Copy link
Contributor

Description

This PR adds support for one-phase commit optimization introduced by scalar-labs/scalardb#2811.

Related issues and/or PRs

Changes made

  • Added support for one-phase commit optimization.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

@brfrn169 brfrn169 self-assigned this Jun 24, 2025
@brfrn169 brfrn169 added the enhancement New feature or request label Jun 24, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a one-phase commit optimization to improve commit performance.

  • Introduces a new command-line flag (--enable-one-phase-commit) in runner.clj.
  • Updates db_extend.clj to set the corresponding DB property based on the new flag.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scalardb/src/scalardb/runner.clj Added new command-line option to enable one-phase commit optimization.
scalardb/src/scalardb/db_extend.clj Updated DB properties to include one-phase commit enabled configuration.

@brfrn169 brfrn169 requested review from feeblefakie and yito88 June 26, 2025 01:00
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

@brfrn169 Sorry, can you fix the conflict?

@brfrn169 brfrn169 merged commit 5967529 into master Jun 27, 2025
4 checks passed
@brfrn169 brfrn169 deleted the support-one-phase-commit branch June 27, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants